From mboxrd@z Thu Jan  1 00:00:00 1970
From: James Morris <jmorris@namei.org>
Subject: Re: [PATCH 11/12: eCryptfs] Keystore
Date: Thu, 3 Nov 2005 18:59:42 -0500 (EST)
Message-ID: <Pine.LNX.4.63.0511031856050.22256@excalibur.intercode>
References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103035611.GK3005@sshock.rn.byu.edu>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com,
	yoder1@us.ibm.com
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S932644AbVKCX7l@vger.kernel.org>
To: Phillip Hellewell <phillip@hellewell.homeip.net>
In-Reply-To: <20051103035611.GK3005@sshock.rn.byu.edu>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, 2 Nov 2005, Phillip Hellewell wrote:

> +	password_s_ptr = &auth_tok->token.password;
> +	if (password_s_ptr->session_key_encryption_key_set) {
> +		ecryptfs_printk(1, KERN_NOTICE, "Session key encryption key "
> +				"set; skipping key generation\n");
> +		goto session_key_encryption_key_set;
> +	}
> +      session_key_encryption_key_set:
> +	ecryptfs_printk(1, KERN_NOTICE, "Session key encryption key (size [%d])"
> +			":\n", password_s_ptr->session_key_encryption_key_size);

Spurious goto?

> +out:
> +	if (tfm)
> +		crypto_free_tfm(tfm);
> +	return rc;

Just call crypto_free_tfm() unconditionally.


- James
-- 
James Morris
<jmorris@namei.org>