From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [PATCH 12/12: eCryptfs] Crypto functions Date: Thu, 3 Nov 2005 19:08:46 -0500 (EST) Message-ID: References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103035659.GL3005@sshock.rn.byu.edu> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from mail25.sea5.speakeasy.net ([69.17.117.27]:4072 "EHLO mail25.sea5.speakeasy.net") by vger.kernel.org with ESMTP id S932699AbVKDAIo (ORCPT ); Thu, 3 Nov 2005 19:08:44 -0500 To: Phillip Hellewell In-Reply-To: <20051103035659.GL3005@sshock.rn.byu.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2 Nov 2005, Phillip Hellewell wrote: > + crypto_cipher_setkey(crypt_stats->tfm, crypt_stats->key, > + crypt_stats->key_size_bits / 8); Check return value. > +static void generate_random_key(unsigned char *key, int num_bytes) > +{ > + get_random_bytes(key, num_bytes); > +} Call get_random_bytes() directly. > + if (likely(1 == crypt_stats->encrypted)) { > + if (!crypt_stats->key_valid) { > + ecryptfs_printk(1, KERN_NOTICE, "Key is " > + "invalid; bailing out\n"); > + rc = -EINVAL; > + goto out; > + } > + } else { > + rc = -EINVAL; > + ecryptfs_printk(0, KERN_WARNING, > + "Called with crypt_stats->encrypted == 0\n"); > + goto out; > + } What's going on here? Is (crypt_stats->encrypted != 1) a kernel bug? - James -- James Morris