From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [PATCH 9/12: eCryptfs] Inode operations Date: Fri, 4 Nov 2005 01:29:46 -0500 (EST) Message-ID: References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103035411.GI3005@sshock.rn.byu.edu> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Phillip Hellewell , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from mail24.sea5.speakeasy.net ([69.17.117.26]:28127 "EHLO mail24.sea5.speakeasy.net") by vger.kernel.org with ESMTP id S1161082AbVKDG3p (ORCPT ); Fri, 4 Nov 2005 01:29:45 -0500 To: Andreas Schwab In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 4 Nov 2005, Andreas Schwab wrote: > James Morris writes: > > > On Wed, 2 Nov 2005, Phillip Hellewell wrote: > > > >> +static int grow_file(struct dentry *ecryptfs_dentry, struct file *lower_file, > >> + struct inode *inode, struct inode *lower_inode) > >> +{ > >> + int rc = 0; > >> + struct file fake_file; > >> + memset(&fake_file, 0, sizeof(fake_file)); > > > > > > You don't need these initializations, bss is always initialized to zero > > in this environment. > > Automatic variables are not related to the bss segment. Yep, ignore whatever it was I was mis-thinking there. - James -- James Morris