Re: [PATCH 1/12: eCryptfs] Makefile and Kconfig

[Anton Altaparmakov <aia21@cam.ac.uk>]

On Fri, 4 Nov 2005, Michael Thompson wrote:
> On 11/3/05, Greg KH <greg@kroah.com> wrote:
> > On Thu, Nov 03, 2005 at 09:21:16AM -0600, Michael Thompson wrote:
> > > On 11/2/05, Phillip Hellewell <phillip@hellewell.homeip.net> wrote:
> > > > These patches modify fs/Makefile and fs/Kconfig to provide build
> > > > support for eCryptfs.
> > > >
> > > > Signed off by: Phillip Hellewell <phillip@hellewell.homeip.net>
> > > > Signed off by: Michael Halcrow <mhalcrow@us.ibm.com>
> > > > Signed off by: Michael Thompson <mmcthomps@us.ibm.com>
> > >
> > > That should read:
> > > Signed off by: Michael Thompson <mcthomps@us.ibm.com>
> >
> > No, that's not how it is documented on how to do this.  Please try
> > again.
> 
> I've just rummaged around in linux/Documentation and I have not been
> able to find, either in a specific file, or by looking at "The Perfect
> Patch", or other related links, on how to fix an incorrect
> "Signed-off-by" line.
> 
> Like I've already said, I have no problems with a RTFM response, but
> point me to the right M.

I have no idea what Greg was talking about either but one thing that is 
obviously wrong is that as you say it should be "Signed-off-by:" and not 
"Signed off by:", i.e. you have to have dashes between the words, not 
spaces.

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/