From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Altaparmakov Subject: Re: [PATCH 1/12: eCryptfs] Makefile and Kconfig Date: Fri, 4 Nov 2005 16:22:58 +0000 (GMT) Message-ID: References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103034207.GA3005@sshock.rn.byu.edu> <20051103230551.GB30487@kroah.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Greg KH , Phillip Hellewell , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from ppsw-7.csi.cam.ac.uk ([131.111.8.137]:40590 "EHLO ppsw-7.csi.cam.ac.uk") by vger.kernel.org with ESMTP id S1751605AbVKDQXK (ORCPT ); Fri, 4 Nov 2005 11:23:10 -0500 To: Michael Thompson In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 4 Nov 2005, Michael Thompson wrote: > On 11/3/05, Greg KH wrote: > > On Thu, Nov 03, 2005 at 09:21:16AM -0600, Michael Thompson wrote: > > > On 11/2/05, Phillip Hellewell wrote: > > > > These patches modify fs/Makefile and fs/Kconfig to provide build > > > > support for eCryptfs. > > > > > > > > Signed off by: Phillip Hellewell > > > > Signed off by: Michael Halcrow > > > > Signed off by: Michael Thompson > > > > > > That should read: > > > Signed off by: Michael Thompson > > > > No, that's not how it is documented on how to do this. Please try > > again. > > I've just rummaged around in linux/Documentation and I have not been > able to find, either in a specific file, or by looking at "The Perfect > Patch", or other related links, on how to fix an incorrect > "Signed-off-by" line. > > Like I've already said, I have no problems with a RTFM response, but > point me to the right M. I have no idea what Greg was talking about either but one thing that is obviously wrong is that as you say it should be "Signed-off-by:" and not "Signed off by:", i.e. you have to have dashes between the words, not spaces. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/