Re: [PATCH] replace inode_update_time with file_update_time

[Anton Altaparmakov <aia21@cam.ac.uk>]

On Tue, 8 Nov 2005, Christoph Hellwig wrote:
> On Mon, Nov 07, 2005 at 10:02:01PM +0000, Anton Altaparmakov wrote:
> > But that is my point!  A read-only bind mount is just like any other 
> > read-only mount and should never even try to update metadata.
> > 
> > Which codepaths cause inode/file_update_time() to be called for a 
> > read-only mount?
> 
> The callers right now are the write methods of the various filesystems,
> so you are right indeed that we shouldn't need it.
>
> > I do not believe there are any!
> > 
> > And assuming that I am correct this makes the IS_RDONLY() check 
> > pointless and this in turn makes the whole patch pointless
> 
> Yes, I think you're right here that we can removed it.

Thank you.  So lets drop it then.
 
> > and given it 
> > breaks existing file systems it should be sent to the nirvana of useless 
> > patches.
> 
> and here I disagree. Given that the only intended use of this function
> is to be used in the ->write methods the file is a useful argument.  The

It does not say so anywhere though...

> only other use that sneaked in recently is ntfs ->truncate that
> shouldn't use and has been fixed by a patch I sent offlist.

Yes, and a nice fix that was, too...  But hey, ntfs is already forced to 
duplicate half of the vfs, a bit more or less will not make any 
difference...

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/