Re: + switch-ntfs-to-touch_atime.patch added to -mm tree

[Anton Altaparmakov <aia21@cam.ac.uk>]

A question...

On Tue, 8 Nov 2005, Christoph Hellwig wrote:
> [ccing -fsdevel now because this is something of interest to the public]
> 
> On Mon, Nov 07, 2005 at 09:51:08PM +0000, Anton Altaparmakov wrote:
> > What callers are those?  I am curious...  The SUS/Posix standard requires 
> > it as I said in previous post (except for the no size change case but 
> > as I also said in previous post the VFS does that wrong in same way as 
> > ntfs and I just copied vfs)...
> 
> Besides the various ->setattr instaces which are supposed to set ctime if
> ATTR_SIZE|ATTR_CTIME are set (which it is for sys_truncate or

How come inode_setattr() sets both c and mtime unconditionally but 
inode/file_update_time() makes the setting conditional on IS_NOCMTIME() 
being false?

It seems that either they should always be set or they should never be 
set when IS_NOCMTIME() is true, and not be set half the time and not half 
the other time, no?

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/