From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Altaparmakov Subject: Re: + switch-ntfs-to-touch_atime.patch added to -mm tree Date: Tue, 8 Nov 2005 10:41:20 +0000 (GMT) Message-ID: References: <200511060035.jA60Zk1U004874@shell0.pdx.osdl.net> <20051106041321.GC30958@lst.de> <20051105203531.7b67c2d8.akpm@osdl.org> <20051107034614.GB16058@lst.de> <20051107115914.GA24006@lst.de> <20051108044310.GC8531@lst.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Andrew Morton , linux-fsdevel@vger.kernel.org Return-path: Received: from ppsw-7.csi.cam.ac.uk ([131.111.8.137]:53735 "EHLO ppsw-7.csi.cam.ac.uk") by vger.kernel.org with ESMTP id S1751258AbVKHKl3 (ORCPT ); Tue, 8 Nov 2005 05:41:29 -0500 To: Christoph Hellwig In-Reply-To: <20051108044310.GC8531@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org A question... On Tue, 8 Nov 2005, Christoph Hellwig wrote: > [ccing -fsdevel now because this is something of interest to the public] > > On Mon, Nov 07, 2005 at 09:51:08PM +0000, Anton Altaparmakov wrote: > > What callers are those? I am curious... The SUS/Posix standard requires > > it as I said in previous post (except for the no size change case but > > as I also said in previous post the VFS does that wrong in same way as > > ntfs and I just copied vfs)... > > Besides the various ->setattr instaces which are supposed to set ctime if > ATTR_SIZE|ATTR_CTIME are set (which it is for sys_truncate or How come inode_setattr() sets both c and mtime unconditionally but inode/file_update_time() makes the setting conditional on IS_NOCMTIME() being false? It seems that either they should always be set or they should never be set when IS_NOCMTIME() is true, and not be set half the time and not half the other time, no? Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/