From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Altaparmakov Subject: Re: + switch-ntfs-to-touch_atime.patch added to -mm tree Date: Tue, 8 Nov 2005 15:58:46 +0000 (GMT) Message-ID: References: <200511060035.jA60Zk1U004874@shell0.pdx.osdl.net> <20051106041321.GC30958@lst.de> <20051105203531.7b67c2d8.akpm@osdl.org> <20051107034614.GB16058@lst.de> <20051107115914.GA24006@lst.de> <20051108044310.GC8531@lst.de> <1131463032.9387.10.camel@kleikamp.austin.ibm.com> <1131463540.32482.34.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Dave Kleikamp , Christoph Hellwig , Andrew Morton , linux-fsdevel@vger.kernel.org Return-path: Received: from ppsw-7.csi.cam.ac.uk ([131.111.8.137]:59112 "EHLO ppsw-7.csi.cam.ac.uk") by vger.kernel.org with ESMTP id S932373AbVKHP7J (ORCPT ); Tue, 8 Nov 2005 10:59:09 -0500 To: Trond Myklebust In-Reply-To: <1131463540.32482.34.camel@lade.trondhjem.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 8 Nov 2005, Trond Myklebust wrote: > On Tue, 2005-11-08 at 09:17 -0600, Dave Kleikamp wrote: > > On Tue, 2005-11-08 at 10:41 +0000, Anton Altaparmakov wrote: > > > How come inode_setattr() sets both c and mtime unconditionally but > > > inode/file_update_time() makes the setting conditional on IS_NOCMTIME() > > > being false? > > > > > > It seems that either they should always be set or they should never be > > > set when IS_NOCMTIME() is true, and not be set half the time and not half > > > the other time, no? > > > > IS_NOCMTIME() is useful to network file systems (nfs specifically) that > > rely on the server setting the ctime & mtime when the inode is modified. > > Of course, if the ctime & mtime are explicitly set by setattr, the > > client will need to change these fields. > > Right. IS_NOCMTIME was introduced to stop the _kernel_ from setting > ctime and mtime on those filesystems for which this is inappropriate. > > It is not intended to prevent the user from doing so. Ok, thanks to both of you for explaining! Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/