linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org, autofs@linux.kernel.org
Subject: Re: [RFC:PATCH 2/4] autofs4 - add v5 follow_link mount trigger method
Date: Mon, 13 Feb 2006 00:53:36 +0800 (WST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0602130052000.2319@eagle.themaw.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0602121542060.1213@yvahk01.tjqt.qr>


On Sun, 12 Feb 2006, Jan Engelhardt wrote:

> >
> >This patch adds a follow_link inode method for the root of
> >an autofs direct mount trigger. It also adds the corresponding
> >mount options and updates the show_mount method.
> >
> >+	if (sbi->type & AUTOFS_TYP_OFFSET)
> >+		seq_printf(m, ",offset");
> >+	else if (sbi->type & AUTOFS_TYP_DIRECT)
> >+		seq_printf(m, ",direct");
> >+	else
> >+		seq_printf(m, ",indirect");
> >+
> 
> Just a little nitpick: in English, it's usually "type" not "typ".

OK. But this was intentional.

In fact the same thought occured to me this evening when I was preparing 
the patches. I'll consider it for the final post.

Thanks
 
> 
> >+#define AUTOFS_TYP_INDIRECT     0x0001
> >+#define AUTOFS_TYP_DIRECT       0x0002
> >+#define AUTOFS_TYP_OFFSET       0x0004
> 
> >+	unsigned int type;
> 
> 
> Jan Engelhardt
> -- 
> 


  reply	other threads:[~2006-02-12 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-12 13:40 [RFC:PATCH 2/4] autofs4 - add v5 follow_link mount trigger method Ian Kent
2006-02-12 14:43 ` Jan Engelhardt
2006-02-12 16:53   ` Ian Kent [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-02-17  7:01 Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0602130052000.2319@eagle.themaw.net \
    --to=raven@themaw.net \
    --cc=autofs@linux.kernel.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).