From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Altaparmakov Subject: truncate and {m,c}time on ntfs Date: Sun, 12 Mar 2006 16:50:24 +0000 (GMT) Message-ID: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from ppsw-9.csi.cam.ac.uk ([131.111.8.139]:5564 "EHLO ppsw-9.csi.cam.ac.uk") by vger.kernel.org with ESMTP id S1751287AbWCLQu5 (ORCPT ); Sun, 12 Mar 2006 11:50:57 -0500 To: Christoph Hellwig Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi Christoph, A patch of yours modified fs/ntfs/inode.c::ntfs_truncate() and inserted this comment: [snip] /* normally ->truncate shouldn't update ctime or mtime, * but ntfs did before so it got a copy & paste version * of file_update_time. one day someone should fix this * for real. */ [snip] Did you realise that all (local) file systems in Linux kernel set both {m,c}time in their ->truncate function. E.g. from fs/ext3.c/inode.c::ext3_truncate(): inode->i_mtime = inode->i_ctime = CURRENT_TIME_SEC; Would you be so kind to explain what is your problem with ntfs doing it, too? And if your statement is correct and no file system should touch {m,c}time in their ->truncate() method, could you explain to me how the {m,c}time would be set otherwise when open(O_TRUNC) or {f,}truncate() is executed on a file? Thanks a lot in advance. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/