* [PATCH] autofs4 - need to invalidate children on tree mount expire
@ 2006-06-12 6:52 Ian Kent
0 siblings, 0 replies; only message in thread
From: Ian Kent @ 2006-06-12 6:52 UTC (permalink / raw)
To: Andrew Morton; +Cc: autofs mailing list, Kernel Mailing List, linux-fsdevel
Hi Andrew,
I've found a case where invalid dentrys in a mount tree, waiting to be
cleaned up by d_invalidate, prevent the expected expire.
In this case dentrys created during a lookup for which a mount fails or
has no entry in the mount map contribute to the d_count of the parent
dentry. These dentrys may not be invalidated prior to comparing the
interanl usage count of valid autofs dentrys against the dentry d_count
which makes a mount tree appear busy so it doesn't expire.
Signed-off-by: Ian Kent <raven@themaw.net>
--
--- linux-2.6.17-rc6-mm2/fs/autofs4/expire.c.need-invalidate-on-tree-expire 2006-06-12 14:24:21.000000000 +0800
+++ linux-2.6.17-rc6-mm2/fs/autofs4/expire.c 2006-06-12 14:24:36.000000000 +0800
@@ -174,6 +174,12 @@ static int autofs4_tree_busy(struct vfsm
struct autofs_info *ino = autofs4_dentry_ino(p);
unsigned int ino_count = atomic_read(&ino->count);
+ /*
+ * Clean stale dentries below that have not been
+ * invalidated after a mount fail during lookup
+ */
+ d_invalidate(p);
+
/* allow for dget above and top is already dgot */
if (p == top)
ino_count += 2;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-12 6:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-12 6:52 [PATCH] autofs4 - need to invalidate children on tree mount expire Ian Kent
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).