linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Al Viro <viro@ftp.linux.org.uk>, Andrew Morton <akpm@osdl.org>
Cc: autofs mailing list <autofs@linux.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] autofs4 needs to force fail return revalidate
Date: Wed, 21 Jun 2006 21:39:25 +0800 (WST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0606212135540.14481@raven.themaw.net> (raw)
In-Reply-To: <20060620233941.49ba2223.akpm@osdl.org>

On Tue, 20 Jun 2006, Andrew Morton wrote:

> 
> Also, did you consider broadening the ->d_revalidate() semantics?  It
> appears that all implementations return 0 or 1.  You could teach the VFS to
> also recognise and act upon a -ve return value, and do this trickery within
> the autofs d_revalidate(), perhaps?
> 

Now it occurs to me this is the only safe way to do this.
And a lot simpler.

Al, given this is such a heavily traveled piece of code, do you think 
it would be acceptable to change the semantics of revalidate in this way.

Ian


  parent reply	other threads:[~2006-06-21 13:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21  6:18 [PATCH] autofs4 needs to force fail return revalidate Ian Kent
2006-06-21  6:39 ` Andrew Morton
2006-06-21 13:07   ` Ian Kent
2006-06-21 13:39   ` Ian Kent [this message]
2006-06-23  4:14   ` Ian Kent
2006-06-23  4:30     ` Andrew Morton
2006-06-23  6:43       ` Ian Kent
2006-07-10 10:24     ` Andrew Morton
2006-07-10 16:23       ` [autofs] " Ian Kent
2006-06-21 12:25 ` Al Viro
2006-06-21 13:05   ` Ian Kent
2006-06-21 13:37 ` [autofs] " Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0606212135540.14481@raven.themaw.net \
    --to=raven@themaw.net \
    --cc=akpm@osdl.org \
    --cc=autofs@linux.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).