From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Zippel Subject: Re: [PATCH 2/9] sector_t format string Date: Thu, 10 Aug 2006 19:24:40 +0200 (CEST) Message-ID: References: <1155172843.3161.81.camel@localhost.localdomain> <20060809234019.c8a730e3.akpm@osdl.org> <44DB203A.6050901@garzik.org> <44DB25C1.1020807@garzik.org> <44DB27A3.1040606@garzik.org> <44DB3151.8050904@garzik.org> <17627.23974.848640.278643@stoffel.org> <20060810095413.3797b4a2.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jeff Garzik , ext2-devel@lists.sourceforge.net, John Stoffel , linux-kernel@vger.kernel.org, cmm@us.ibm.com, linux-fsdevel@vger.kernel.org Return-path: To: Andrew Morton In-Reply-To: <20060810095413.3797b4a2.akpm@osdl.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ext2-devel-bounces@lists.sourceforge.net Errors-To: ext2-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org Hi, On Thu, 10 Aug 2006, Andrew Morton wrote: > For ext3 on x86: > > CONFIG_LBD=y: > > box:/usr/src/25> size fs/jbd/jbd.o fs/ext3/ext3.o > text data bss dec hex filename > 51076 8 32 51116 c7ac fs/jbd/jbd.o > 87466 1020 4 88490 159aa fs/ext3/ext3.o > > CONFIG_LBD=n: > > box:/usr/src/25> size fs/jbd/jbd.o fs/ext3/ext3.o > text data bss dec hex filename > 51133 8 32 51173 c7e5 fs/jbd/jbd.o > 87679 1020 4 88703 15a7f fs/ext3/ext3.o > > That's a grand total of 270 bytes of text saved. aka 0.19%. > > We'll save four bytes in the inode (unlikely to save anything due to slab > packing). sector_t is used in multiple structures (bio/request/buffer_head), which quickly adds up. ext3 is also currently not a very heavy sector_t user, if you try this with block/ you get a more than 3% difference. bye, Roman ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642