From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Bodo Eggert <7eggert@gmx.de>,
akpm@osdl.org, dev@sw.ru, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] pipefs unique inode numbers
Date: Tue, 30 Jan 2007 17:28:38 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701301726280.3611@woody.linux-foundation.org> (raw)
In-Reply-To: <45BFEE85.30203@redhat.com>
On Tue, 30 Jan 2007, Jeff Layton wrote:
>
> Also, that patch would break many 32-bit programs not compiled with large
> offsets when run in compatibility mode on a 64-bit kernel. If they were to
> do a stat on this inode, it would likely generate an EOVERFLOW error since
> the pointer address would probably not fit in a 32 bit field.
>
> That problem was the whole impetus for this set of patches.
Well, we have that problem with the slowly incrementing "last_ino" too.
Should we make "last_ino" be "static unsigned int" instead of "long"?
Does anybody actually even use the old stat() with 32-bit interfaces? We
warn for it, and we've done so for a long time.. I dont' remember people
even complaining about the warning, so..
Linus
next prev parent reply other threads:[~2007-01-31 1:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 22:40 [PATCH] pipefs unique inode numbers Bodo Eggert
2007-01-30 22:55 ` Linus Torvalds
2007-01-31 0:12 ` Jeff Layton
2007-01-31 1:19 ` Jeff Layton
2007-01-31 1:28 ` Linus Torvalds [this message]
2007-01-31 2:02 ` Jeff Layton
2007-01-31 9:19 ` Kirill Korotaev
2007-01-31 1:37 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701301726280.3611@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=7eggert@gmx.de \
--cc=akpm@osdl.org \
--cc=dev@sw.ru \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).