linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pekka J Enberg <penberg@cs.helsinki.fi>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC/PATCH 2/5] revoke: core code
Date: Wed, 11 Jul 2007 13:01:07 +0300 (EEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707111251280.12522@sbz-30.cs.Helsinki.FI> (raw)
In-Reply-To: <20070711093732.GU21668@ftp.linux.org.uk>

On Wed, 11 Jul 2007, Al Viro wrote:
> BTW, read() or write() in progress might get rather unhappy if your
> live replacement of ->f_mapping races with them...

For writes, we (1) never start any new operations after we've cleaned up 
the file descriptor tables so (2) after we're done with do_fsync() we 
never touch ->f_mapping again.

But for reads, I think there's a problem if we're in 
do_generic_mapping_read() doing invalidate_inode_pages2() is not enough 
because we're hanging on to the real mapping. Hmm.

			Pekka

  parent reply	other threads:[~2007-07-11 10:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-11  9:01 [RFC/PATCH 2/5] revoke: core code Pekka J Enberg
2007-07-11  9:37 ` Al Viro
2007-07-11  9:42   ` Al Viro
2007-07-11  9:50     ` Pekka J Enberg
2007-07-11 10:09       ` Al Viro
2007-07-11 10:54         ` Pekka J Enberg
2007-07-11 10:01   ` Pekka J Enberg [this message]
2007-07-11 10:18     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707111251280.12522@sbz-30.cs.Helsinki.FI \
    --to=penberg@cs.helsinki.fi \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).