From: Pekka J Enberg <penberg@cs.helsinki.fi>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC/PATCH 2/5] revoke: core code
Date: Wed, 11 Jul 2007 13:54:16 +0300 (EEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707111351420.30386@sbz-30.cs.Helsinki.FI> (raw)
In-Reply-To: <20070711100959.GW21668@ftp.linux.org.uk>
Hi,
On Wed, 11 Jul 2007, Al Viro wrote:
> The fundamental issue here is that even if you do find struct file,
> you can't blindly rip its ->f_mapping since it can be in the middle
> of ->read(), ->write(), pageout, etc. And even if you do manage
> that, you still have the ability to do fchmod() later.
Then we would need to change the VFS and relevant parts so that we can
take down ->f_mapping. I don't see how we could do that without affecting
current hotpaths. Hmm. I suppose what we really need to do is cannibalize
the actual inode (remove from inode cache, detach from dentry and take
down the mapping) so that we don't have to touch existing struct file
pointers at all.
Pekka
next prev parent reply other threads:[~2007-07-11 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 9:01 [RFC/PATCH 2/5] revoke: core code Pekka J Enberg
2007-07-11 9:37 ` Al Viro
2007-07-11 9:42 ` Al Viro
2007-07-11 9:50 ` Pekka J Enberg
2007-07-11 10:09 ` Al Viro
2007-07-11 10:54 ` Pekka J Enberg [this message]
2007-07-11 10:01 ` Pekka J Enberg
2007-07-11 10:18 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707111351420.30386@sbz-30.cs.Helsinki.FI \
--to=penberg@cs.helsinki.fi \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).