From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Subject: Re: [00/41] Large Blocksize Support V7 (adds memmap support) Date: Tue, 18 Sep 2007 13:42:09 -0700 (PDT) Message-ID: References: <20070911060349.993975297@sgi.com> <200709161822.47879.nickpiggin@yahoo.com.au> <200709181010.28043.nickpiggin@yahoo.com.au> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Mel Gorman , andrea@suse.de, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Mel Gorman , William Lee Irwin III , David Chinner , Jens Axboe , Badari Pulavarty , Maxim Levitsky , Fengguang Wu , swin wang , totty.lu@gmail.com, hugh@veritas.com, joern@lazybastard.org To: Nick Piggin Return-path: Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:35848 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755451AbXIRUmM (ORCPT ); Tue, 18 Sep 2007 16:42:12 -0400 In-Reply-To: <200709181010.28043.nickpiggin@yahoo.com.au> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 18 Sep 2007, Nick Piggin wrote: > > We can avoid all doubt in this patchset as well by adding support for > > fallback to a vmalloced compound page. > > How would you do a vmapped fallback in your patchset? How would > you keep track of pages 2..N if they don't exist in the radix tree? Through the vmalloc structures and through the conventions established for compound pages? > What if they don't even exist in the kernel's linear mapping? It seems > you would also require more special casing in the fault path and special > casing in the block layer to do this. Well yeah there is some sucky part about vmapping things (same as in yours, possibly more in mine since its general and not specific to the page cache). On the other hand a generic vcompound fallback will allow us to use the page allocator in many places where we currently have to use vmalloc because the allocations are too big. It will allow us to get rid of most of the vmalloc uses and thereby reduce TLB pressure somewhat. The vcompound patchset is almost ready..... Maybe bits and pieces may even help fsblock.