Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

[Davide Libenzi <davidel@xmailserver.org>]

On Wed, 26 Sep 2007, Andrew Morton wrote:

> On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <yanzheng@21cn.com> wrote:
> 
> > Hello,
> > 
> > igrab return NULL on error.
> > 
> > Signed-off-by: Yan Zheng<yanzheng@21cn.com>
> > ---
> > diff -ur linux-2.6.23-rc8/fs/anon_inodes.c linux/fs/anon_inodes.c
> > --- linux-2.6.23-rc8/fs/anon_inodes.c	2007-09-27 10:05:07.000000000 +0800
> > +++ linux/fs/anon_inodes.c	2007-09-27 10:18:26.000000000 +0800
> > @@ -87,8 +87,8 @@
> >  		return -ENFILE;
> > 
> >  	inode = igrab(anon_inode_inode);
> > -	if (IS_ERR(inode)) {
> > -		error = PTR_ERR(inode);
> > +	if (!inode) {
> > +		error = -ENOENT;
> >  		goto err_put_filp;
> >  	}
> 
> hm, does that code actually need to exist?  igrab() is pretty expensive and
> that fs is permanently mounted anyway...

yes. The inode gets attached the the file*, and on its way out an iput() 
is done.
Funny, I noticed the non-ERR_PTR return code of igrab() just yesterday, 
and I was going to port a patch today.


Signed-off-by: Davide Libenzi <davidel@xmailserver.org>



- Davide