From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Subject: Re: [13/17] Virtual compound page freeing in interrupt context Date: Fri, 28 Sep 2007 10:35:44 -0700 (PDT) Message-ID: References: <20070925234204.546836393@sgi.com> <20070925234252.220601640@sgi.com> <20070928135255.80dd7575.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: KAMEZAWA Hiroyuki Return-path: Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:52077 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753128AbXI1Rfp (ORCPT ); Fri, 28 Sep 2007 13:35:45 -0400 In-Reply-To: <20070928135255.80dd7575.kamezawa.hiroyu@jp.fujitsu.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 28 Sep 2007, KAMEZAWA Hiroyuki wrote: > On Tue, 25 Sep 2007 16:42:17 -0700 > Christoph Lameter wrote: > > > +static noinline void vcompound_free(void *addr) > > +{ > > + if (in_interrupt()) { > > Should be (in_interrupt() || irqs_disabled()) ? Maybe only irqs_disabled()?