From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Subject: Re: [patch 16/19] Use page_cache_xxx in fs/ext4 Date: Wed, 28 Nov 2007 19:58:45 -0800 (PST) Message-ID: References: <20071129011052.866354847@sgi.com> <20071129011148.032437954@sgi.com> <20071129034857.GW119954183@sgi.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Mel Gorman , William Lee Irwin III , Jens Axboe , Badari Pulavarty , Maxim Levitsky , Fengguang Wu , swin wang , totty.lu@gmail.com, hugh@veritas.com, joern@lazybastard.org To: David Chinner Return-path: Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:48702 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751239AbXK2D6q (ORCPT ); Wed, 28 Nov 2007 22:58:46 -0500 In-Reply-To: <20071129034857.GW119954183@sgi.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 29 Nov 2007, David Chinner wrote: > These three should use the pagesize variable. ext4: use pagesize variable instead of the inline function Signed-off-by: Christoph Lameter --- fs/ext4/inode.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) Index: mm/fs/ext4/inode.c =================================================================== --- mm.orig/fs/ext4/inode.c 2007-11-28 19:56:18.234382799 -0800 +++ mm/fs/ext4/inode.c 2007-11-28 19:57:10.774132672 -0800 @@ -1693,17 +1693,16 @@ static int ext4_journalled_writepage(str * doesn't seem much point in redirtying the page here. */ ClearPageChecked(page); - ret = block_prepare_write(page, 0, page_cache_size(mapping), - ext4_get_block); + ret = block_prepare_write(page, 0, pagesize, ext4_get_block); if (ret != 0) { ext4_journal_stop(handle); goto out_unlock; } ret = walk_page_buffers(handle, page_buffers(page), 0, - page_cache_size(mapping), NULL, do_journal_get_write_access); + pagesize, NULL, do_journal_get_write_access); err = walk_page_buffers(handle, page_buffers(page), 0, - page_cache_size(mapping), NULL, write_end_fn); + pagesize, NULL, write_end_fn); if (ret == 0) ret = err; EXT4_I(inode)->i_state |= EXT4_STATE_JDATA;