From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Lameter <clameter@sgi.com>
Subject: Re: [patch 01/19] Define functions for page cache handling
Date: Thu, 29 Nov 2007 11:23:55 -0800 (PST)
Message-ID: <Pine.LNX.4.64.0711291123350.25803@schroedinger.engr.sgi.com>
References: <20071129011052.866354847@sgi.com> <20071129011144.503535436@sgi.com>
 <396325866.00706@ustc.edu.cn>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Christoph Hellwig <hch@lst.de>,
	Mel Gorman <mel@skynet.ie>,
	William Lee Irwin III <wli@holomorphy.com>,
	David Chinner <dgc@sgi.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Badari Pulavarty <pbadari@gmail.com>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Fengguang Wu <fengguang.wu@gmail.com>,
	swin wang <wangswin@gmail.com>, totty.lu@gmail.com,
	hugh@veritas.com, joern@lazybastard.org
To: Fengguang Wu <wfg@mail.ustc.edu.cn>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:41370 "EHLO
	relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1761736AbXK2TYE (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 29 Nov 2007 14:24:04 -0500
In-Reply-To: <396325866.00706@ustc.edu.cn>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, 29 Nov 2007, Fengguang Wu wrote:

> On Wed, Nov 28, 2007 at 05:10:53PM -0800, Christoph Lameter wrote:
> > +static inline loff_t page_cache_mask(struct address_space *a)
> > +{
> > +	return (loff_t)PAGE_MASK;
> > +}
> 
> A tiny question: Why choose loff_t instead of 'unsigned long'?
> 
> It's not obvious because page_cache_mask() is not referenced in this
> patchset at all ;-)

Ok Then lets drop page_cache_mask completely.