From: Pekka J Enberg <penberg@cs.helsinki.fi>
To: Christoph Hellwig <hch@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
alan@redhat.com, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC/PATCH 4/8] revoke: core code V7
Date: Wed, 16 Jan 2008 10:35:32 +0200 (EET) [thread overview]
Message-ID: <Pine.LNX.4.64.0801161029160.27552@sbz-30.cs.Helsinki.FI> (raw)
In-Reply-To: <20080115172741.GA20388@infradead.org>
Hi,
On Tue, 15 Jan 2008, Christoph Hellwig wrote:
> Something like the loop above is not going to go in for sure. Once we
> get rid of the sb->s_files we can put the list_head in struct file to
> new use eventually if we don't want to get rid of it. E.g. and
> per-inode list would be much better than the per-superblock one and
> would regularize what the tty driver is doing.
Sure, adding a list of struct files to struct inode obviously works for
me. But it does increase the size of struct inode which I thought you're
not allowed to do ;-)
Anyway, there are still some other problems with this patch if we want to
use it to implement forced unmount (my bad, we can't go changing struct
inode because it's shared by different mount points).
Pekka
next prev parent reply other threads:[~2008-01-16 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 15:16 [RFC/PATCH 4/8] revoke: core code V7 Pekka J Enberg
2008-01-15 15:14 ` Peter Zijlstra
2008-01-15 17:27 ` Christoph Hellwig
2008-01-16 8:35 ` Pekka J Enberg [this message]
2008-04-13 20:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0801161029160.27552@sbz-30.cs.Helsinki.FI \
--to=penberg@cs.helsinki.fi \
--cc=alan@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).