From: Mikulas Patocka <mpatocka@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Valerie Aurora <val@vaaconsulting.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
dm-devel@redhat.com,
Christopher Chaltain <christopher.chaltain@canonical.com>,
esandeen@redhat.com, Surbhi Palande <csurbhi@gmail.com>
Subject: Re: [PATCH] deadlock with suspend and quotas
Date: Tue, 29 Nov 2011 07:54:28 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.1111290746230.10352@hs20-bc2-1.build.redhat.com> (raw)
In-Reply-To: <20111129111136.GC5635@quack.suse.cz>
> > This is technically impossible to achieve on ext2, fat or other
> > non-transactional filesystems. These filesystems have no locks around code
> > paths that set data or inodes dirty. And you still need working sync for
> > ext2. So the best thing to do in sync is to wait until the filesystem is
> > unfrozen.
> Then suspend is effectively unsupported on the filesystem and should
> return EOPNOTSUPP? At least that's what I'd expect...
>
> Honza
> --
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
LVM uses suspend every time it changes layout of the logical volume. For
example when it converts to/from mirrored format, extends/shrinks the
volume, moves the volume to a different disk, takes a snapshots, merges a
snapshot back, on mirror or multipath failover.
For most of these actions (except taking a snapshot) it is irrelevant if
there are dirty data in the filesystem cache or not while it is suspended.
So there is no point in banning suspend on ext2. If you banned it, you
couldn't use ext2 on LVM at all.
Mikulas
next prev parent reply other threads:[~2011-11-29 12:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 20:25 [PATCH] deadlock with suspend and quotas Mikulas Patocka
2011-11-28 15:04 ` Jan Kara
2011-11-28 21:00 ` Valerie Aurora
2011-11-28 21:14 ` Mikulas Patocka
2011-11-28 23:32 ` Mikulas Patocka
2011-11-29 10:19 ` Jan Kara
2011-11-29 10:21 ` Jan Kara
2011-11-29 11:06 ` Mikulas Patocka
2011-11-29 11:11 ` Jan Kara
2011-11-29 12:54 ` Mikulas Patocka [this message]
2011-11-29 13:09 ` Jan Kara
2011-11-29 13:18 ` [dm-devel] " Alasdair G Kergon
2011-11-29 13:32 ` Jan Kara
2011-11-29 16:33 ` Eric Sandeen
2011-11-30 6:52 ` Mikulas Patocka
2011-11-30 11:16 ` Jan Kara
2011-11-30 12:14 ` Mikulas Patocka
2011-11-30 13:05 ` Alasdair G Kergon
2011-11-30 16:53 ` Jan Kara
2011-11-30 17:09 ` Mikulas Patocka
2011-11-30 13:33 ` Alasdair G Kergon
2011-11-30 13:48 ` Alasdair G Kergon
2011-11-30 16:36 ` Mikulas Patocka
2011-11-30 16:34 ` Mikulas Patocka
2011-12-01 0:34 ` Jan Kara
2011-11-30 14:09 ` Alasdair G Kergon
2011-11-30 16:53 ` Mikulas Patocka
2011-12-01 0:03 ` Jan Kara
2011-11-30 17:03 ` Mikulas Patocka
2011-11-29 20:00 ` Kamal Mostafa
2012-01-03 3:30 ` Al Viro
2012-01-03 18:22 ` Mikulas Patocka
2012-01-03 18:35 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1111290746230.10352@hs20-bc2-1.build.redhat.com \
--to=mpatocka@redhat.com \
--cc=christopher.chaltain@canonical.com \
--cc=csurbhi@gmail.com \
--cc=dm-devel@redhat.com \
--cc=esandeen@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=val@vaaconsulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).