linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: Jeff Chua <jeff.chua.linux@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jan Kara <jack@suse.cz>, lkml <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Recent kernel "mount" slow
Date: Sat, 24 Nov 2012 16:09:37 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1211241555470.4300@file.rdu.redhat.com> (raw)
In-Reply-To: <CAAJw_ZvXGKcjfOAS_tRdXJ9SjpCKw1t7rNt+Q=ieCkVJwN2qcg@mail.gmail.com>



On Sat, 24 Nov 2012, Jeff Chua wrote:

> On Fri, Nov 23, 2012 at 9:24 PM, Jens Axboe <axboe@kernel.dk> wrote:
> > On 2012-11-22 20:21, Linus Torvalds wrote:
> >> Doesn't sound like a fsdevel issue since it seems to be independent of
> >> filesystems. More like some generic block layer thing. Adding Jens
> >> (and quoting the whole thing)
> >>
> >> Jens, any ideas? Most of your stuff came in after -rc2, which would
> >> fit with the fact that most of the slowdown seems to be after -rc2
> >> according to Jeff.
> >
> > No ideas. Looking at what went in from my side, only the rq plug sorting
> > is a core change, and that should not cause any change in behaviour for
> > a single device. That's commit 975927b9.
> >
> >> Jeff, more bisecting would be good, though.
> >
> > Probably required, yes...
> 
> 
> This one slows mount from 0.012s to 0.168s.
> 
> commit 62ac665ff9fc07497ca524bd20d6a96893d11071
> Author: Mikulas Patocka <mpatocka@redhat.com>
> Date:   Wed Sep 26 07:46:43 2012 +0200
> 
>     blockdev: turn a rw semaphore into a percpu rw semaphore
> 
> 
> There were couple of more changes to percpu-rw-semaphores after
> 3.7.0-rc2 and those slows mount further from 0.168s to 0.500s. I don't
> really know, but I'm suspecting these. Still bisecting.

The problem there is that you either use normal semaphores and slow down 
I/O or you use percpu-semaphores, you don't slow down I/O, but you slow 
down mount.

So it's better to slow down mount.

(if you don't use any semaphore at all, as it was in 3.6 kernel and 
before, there is a race condition that can crash the kernel if someone 
does mount and direct I/O read on the same device at the same time)

You can improve mount time if you change all occurences of 
synchronize_sched() in include/linux/percpu-rwsem.h to 
synchronize_sched_expedited().

But some people say that synchronize_sched_expedited() is bad for real 
time latency. (can there be something like: if (realtime) 
synchronize_sched(); else synchronize_sched_expedited(); ?)

Mikulas

  parent reply	other threads:[~2012-11-24 21:09 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAJw_ZtbhE5Jtd4PsWx8a23QdFTW7aMrKBmRf-bo5Wrean9Xhg@mail.gmail.com>
2012-11-20 18:09 ` Recent kernel "mount" slow Jan Kara
2012-11-21 15:46   ` Jeff Chua
2012-11-22 14:30     ` Jeff Chua
2012-11-22 19:21       ` Linus Torvalds
2012-11-23 13:24         ` Jens Axboe
2012-11-23 22:21           ` Jeff Chua
2012-11-23 23:31             ` Jeff Chua
2012-11-23 23:48               ` Jeff Chua
2012-11-24 21:09             ` Mikulas Patocka [this message]
2012-11-24 23:23               ` Jeff Chua
2012-11-27  5:57                 ` Jeff Chua
2012-11-27  7:38                   ` Jens Axboe
2012-11-27  7:44                     ` Jens Axboe
2012-11-27  8:45                       ` Jeff Chua
2012-11-27 10:06                     ` Jeff Chua
2012-11-27 12:33                       ` Jens Axboe
2012-11-28  3:57                         ` Mikulas Patocka
2012-11-28  8:33                           ` Jens Axboe
2012-11-28 13:05                             ` Jeff Chua
2012-11-28 17:25                             ` [PATCH] Introduce a method to catch mmap_region (was: Recent kernel "mount" slow) Mikulas Patocka
2012-11-28 19:15                               ` Linus Torvalds
2012-11-28 19:43                                 ` Al Viro
2012-11-28 19:53                                   ` Linus Torvalds
2012-11-28 22:01                                   ` [PATCH v2] Do a proper locking for mmap and block size change Mikulas Patocka
2012-11-29 17:19                                     ` Linus Torvalds
2012-11-29 18:23                                       ` Mikulas Patocka
2012-11-29 18:46                                         ` Linus Torvalds
2012-11-29 19:02                                       ` Linus Torvalds
2012-11-29 19:15                                         ` Chris Mason
2012-11-29 19:26                                           ` Linus Torvalds
2012-11-29 19:48                                             ` Chris Mason
2012-11-29 19:55                                               ` Linus Torvalds
2012-11-29 20:10                                                 ` Linus Torvalds
2012-11-29 20:52                                               ` Linus Torvalds
2012-11-29 21:29                                                 ` Chris Mason
2012-11-29 22:16                                                   ` Linus Torvalds
2012-11-29 22:36                                                     ` Linus Torvalds
2012-11-30  1:16                                                       ` Chris Mason
2012-11-30  2:13                                                         ` Linus Torvalds
2012-11-30  2:27                                                           ` Chris Mason
2012-11-30  2:49                                                     ` Dave Chinner
2012-11-30 14:31                                                       ` Chris Mason
2012-11-30 16:42                                                         ` Linus Torvalds
2012-11-30 16:36                                                       ` Christoph Hellwig
2012-11-30 22:40                                                         ` Dave Chinner
2012-11-30 23:09                                                           ` Christoph Hellwig
2012-11-29 19:50                                             ` Linus Torvalds
2012-11-28 19:50                                 ` [PATCH] Introduce a method to catch mmap_region (was: Recent kernel "mount" slow) Mikulas Patocka
2012-11-28 20:03                                   ` Linus Torvalds
2012-11-28 20:13                                     ` Linus Torvalds
2012-11-28 20:32                                       ` Linus Torvalds
2012-11-28 20:47                                         ` Linus Torvalds
2012-11-28 22:10                                           ` Mikulas Patocka
2012-11-28 21:29                                       ` Mikulas Patocka
2012-11-28 22:52                                         ` Linus Torvalds
2012-11-28 23:13                                           ` Linus Torvalds
2012-11-29  1:20                                             ` Mikulas Patocka
2012-11-29  0:38                                           ` Mikulas Patocka
2012-11-29  2:04                                             ` Linus Torvalds
2012-11-29  2:58                                               ` Linus Torvalds
2012-11-29  6:16                                                 ` Linus Torvalds
2012-11-29  6:25                                                   ` Al Viro
2012-11-29  6:30                                                     ` Al Viro
2012-11-29  6:37                                                       ` Linus Torvalds
2012-11-29  6:45                                                         ` Al Viro
2012-11-29 10:57                                                           ` Jeff Chua
2012-11-29  6:33                                                     ` Linus Torvalds
2012-11-29 14:12                                                   ` Chris Mason
2012-11-29 17:26                                                     ` Chris Mason
2012-11-29 17:26                                                     ` Linus Torvalds
2012-11-29 17:51                                                       ` Chris Mason
2012-11-29 18:12                                                         ` Linus Torvalds
2012-11-28  3:59                       ` [PATCH 1/2] percpu-rwsem: use synchronize_sched_expedited Mikulas Patocka
2012-11-28  4:01                         ` [PATCH 2/2] block_dev: don't take the write lock if block size doesn't change Mikulas Patocka
2012-11-28 14:24                           ` Jeff Chua
2012-11-28 22:03                             ` Mikulas Patocka
2012-11-28 14:19                         ` [PATCH 1/2] percpu-rwsem: use synchronize_sched_expedited Jeff Chua
2012-11-30  0:06                         ` Andrew Morton
2012-11-30  3:00                           ` Mikulas Patocka
2012-11-30 13:42                             ` Paul E. McKenney
2012-11-30 18:57                           ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1211241555470.4300@file.rdu.redhat.com \
    --to=mpatocka@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=jeff.chua.linux@gmail.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).