Re: [PATCH 1/6] iomap: convert iomap_dio_rw() to an args structure

Christoph Hellwig
2021-01-12T10:32:42Z

On Tue, Jan 12, 2021 at 12:07:41PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Adding yet another parameter to the iomap_dio_rw() interface means
> changing lots of filesystems to add the parameter. Convert this
> interface to an args structure so in future we don't need to modify
> every caller to add a new parameter.

I don't like this at all - it leads to bloating of both the source and
binary code without a good reason as you're only passing additional
flags. Converting the existing wait_for_completion to flags value gives
you everyting you need while both being more readable and generating
better code.