From: James Morris <jmorris@namei.org>
To: "David P. Quigley" <dpquigl@tycho.nsa.gov>
Cc: linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Stephen Smalley <sds@tycho.nsa.gov>,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH 1/2] VFS/Security: Rework inode_getsecurity and callers to return resulting buffer
Date: Wed, 24 Oct 2007 09:38:01 +1000 (EST) [thread overview]
Message-ID: <Xine.LNX.4.64.0710240935190.10783@us.intercode.com.au> (raw)
In-Reply-To: <1193080250.30930.6.camel@moss-terrapins.epoch.ncsc.mil>
On Mon, 22 Oct 2007, David P. Quigley wrote:
> +static inline int security_inode_getsecurity(const struct inode *inode,
> + const char *name,
> + void **buffer)
It's better to keep function declarations on one line if possible (the
80-col rule can be broken for this).
But in any case, it looks ok to me.
Acked-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2007-10-23 23:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 19:06 [RFC 0/2] getsecurity/vfs_getxattr cleanup David P. Quigley
2007-10-22 19:10 ` [PATCH 1/2] VFS/Security: Rework inode_getsecurity and callers to return resulting buffer David P. Quigley
2007-10-23 23:38 ` James Morris [this message]
2007-10-26 0:02 ` Serge E. Hallyn
2007-10-26 14:50 ` David P. Quigley
2007-10-26 15:02 ` Serge E. Hallyn
2007-10-26 15:04 ` Stephen Smalley
2007-10-26 15:35 ` Serge E. Hallyn
2007-10-26 15:13 ` David P. Quigley
2007-10-26 15:20 ` David P. Quigley
2007-10-26 15:54 ` David P. Quigley
2007-10-26 16:36 ` Serge E. Hallyn
2007-10-26 17:36 ` David P. Quigley
2007-10-26 15:07 ` Serge E. Hallyn
2007-10-26 15:16 ` David P. Quigley
2007-10-26 22:14 ` James Morris
2007-10-31 20:55 ` David P. Quigley
2007-11-01 3:56 ` James Morris
2007-10-22 19:11 ` [PATCH 2/2] VFS: Reorder vfs_getxattr to avoid unnecessary calls to the LSM David P. Quigley
2007-10-23 23:42 ` James Morris
2007-10-25 23:43 ` Serge E. Hallyn
2007-10-23 20:17 ` [RFC 0/2] getsecurity/vfs_getxattr cleanup David P. Quigley
-- strict thread matches above, loose matches on Subject: below --
2007-11-01 14:35 [PATCH 0/2] getsecurity/vfs_getxattr cleanup V2 David P. Quigley
2007-11-01 14:40 ` [PATCH 1/2] VFS/Security: Rework inode_getsecurity and callers to return resulting buffer David P. Quigley
2007-11-01 20:58 ` James Morris
2007-11-01 22:43 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Xine.LNX.4.64.0710240935190.10783@us.intercode.com.au \
--to=jmorris@namei.org \
--cc=dpquigl@tycho.nsa.gov \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).