From mboxrd@z Thu Jan  1 00:00:00 1970
From: James Morris <jmorris@namei.org>
Subject: Re: [PATCH 1/2] VFS/Security: Rework inode_getsecurity and callers
 to return resulting buffer
Date: Wed, 24 Oct 2007 09:38:01 +1000 (EST)
Message-ID: <Xine.LNX.4.64.0710240935190.10783@us.intercode.com.au>
References: <1193079974.30930.2.camel@moss-terrapins.epoch.ncsc.mil>
 <1193080250.30930.6.camel@moss-terrapins.epoch.ncsc.mil>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: linux-security-module@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@ftp.linux.org.uk>
To: "David P. Quigley" <dpquigl@tycho.nsa.gov>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from namei.org ([69.55.235.186]:51362 "EHLO us.intercode.com.au"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1752367AbXJWXiY (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 23 Oct 2007 19:38:24 -0400
In-Reply-To: <1193080250.30930.6.camel@moss-terrapins.epoch.ncsc.mil>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, 22 Oct 2007, David P. Quigley wrote:

> +static inline int security_inode_getsecurity(const struct inode *inode,
> +						const char *name,
> +						void **buffer)

It's better to keep function declarations on one line if possible (the 
80-col rule can be broken for this).

But in any case, it looks ok to me.


Acked-by: James Morris <jmorris@namei.org>


-- 
James Morris
<jmorris@namei.org>