From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [PATCH 11/11] NFSD: Server implementation of MAC Labeling Date: Thu, 28 Feb 2008 12:46:56 +1100 (EST) Message-ID: References: <1204150294-4678-1-git-send-email-dpquigl@tycho.nsa.gov> <1204150294-4678-12-git-send-email-dpquigl@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: hch@infradead.org, viro@ftp.linux.org.uk, trond.myklebust@fys.uio.no, bfields@fieldses.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "David P. Quigley" Return-path: Received: from namei.org ([69.55.235.186]:49168 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753179AbYB1Bra (ORCPT ); Wed, 27 Feb 2008 20:47:30 -0500 In-Reply-To: <1204150294-4678-12-git-send-email-dpquigl@tycho.nsa.gov> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 27 Feb 2008, David P. Quigley wrote: > + > + if (len > NFS4_MAXLABELLEN) { > + err = nfserrno(len); > + goto out_err; > + } In this case, len is not an errno and should not be passed to nfserrno(). - James -- James Morris