From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [PATCH 08/11] NFS: Introduce lifecycle management for label attribute. Date: Fri, 29 Feb 2008 10:00:12 +1100 (EST) Message-ID: References: <1204144786-3502-1-git-send-email-dpquigl@tycho.nsa.gov> <1204144786-3502-9-git-send-email-dpquigl@tycho.nsa.gov> <1204229267.24345.91.camel@moss-terrapins.epoch.ncsc.mil> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: hch@infradead.org, viro@ftp.linux.org.uk, trond.myklebust@fys.uio.no, bfields@fieldses.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Dave Quigley Return-path: Received: from namei.org ([69.55.235.186]:37407 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758574AbYB1XA6 (ORCPT ); Thu, 28 Feb 2008 18:00:58 -0500 In-Reply-To: <1204229267.24345.91.camel@moss-terrapins.epoch.ncsc.mil> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 28 Feb 2008, Dave Quigley wrote: > A question about the debug configuration here. Exactly what information > are we looking to get for debugging. If we want line/file/function that > these are called on then I need a macro wrapper for the allocation as > well. If that is the case I'm guessing we always define the macros > nfs_fattr_alloc and nfs_fattr_fini and just make the internal functions > static inline so they can be compiled away when !CONFIG_SECURITY. Well, a WARN_ON will give you a stack trace. It's up to you -- how much debugging do you think this will need now? - James -- James Morris