From: James Morris <jmorris@namei.org>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
viro@ZenIV.linux.org.uk,
Andrew Morton <akpm@linux-foundation.org>,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] vfs: make security_inode_setattr() calling consistent
Date: Thu, 31 Jul 2008 07:52:42 +1000 (EST) [thread overview]
Message-ID: <Xine.LNX.4.64.0807310736520.28737@us.intercode.com.au> (raw)
In-Reply-To: <1217428647.20373.235.camel@moss-spartans.epoch.ncsc.mil>
On Wed, 30 Jul 2008, Stephen Smalley wrote:
> Unfortunate since we'd prefer to have the DAC checks applied first, and
> since inode_change_ok() may alter the ia_mode in response to those
> checks, but it does seem inconsistent at present and it doesn't yield
> any difference in the ltp selinux testsuite results.
No LSM seems to be using ia_mode, so that aspect is ok. The DAC checks
are generally not being applied first currently, so common case behaviour
doesn't change with this patch.
Acked-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2008-07-30 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 12:06 [patch] vfs: make security_inode_setattr() calling consistent Miklos Szeredi
2008-07-30 14:37 ` Stephen Smalley
2008-07-30 21:52 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Xine.LNX.4.64.0807310736520.28737@us.intercode.com.au \
--to=jmorris@namei.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sds@tycho.nsa.gov \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).