From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [patch] vfs: make security_inode_setattr() calling consistent Date: Thu, 31 Jul 2008 07:52:42 +1000 (EST) Message-ID: References: <1217428647.20373.235.camel@moss-spartans.epoch.ncsc.mil> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Miklos Szeredi , viro@ZenIV.linux.org.uk, Andrew Morton , linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Stephen Smalley Return-path: Received: from namei.org ([69.55.235.186]:47977 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752349AbYG3VxL (ORCPT ); Wed, 30 Jul 2008 17:53:11 -0400 In-Reply-To: <1217428647.20373.235.camel@moss-spartans.epoch.ncsc.mil> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 30 Jul 2008, Stephen Smalley wrote: > Unfortunate since we'd prefer to have the DAC checks applied first, and > since inode_change_ok() may alter the ia_mode in response to those > checks, but it does seem inconsistent at present and it doesn't yield > any difference in the ltp selinux testsuite results. No LSM seems to be using ia_mode, so that aspect is ok. The DAC checks are generally not being applied first currently, so common case behaviour doesn't change with this patch. Acked-by: James Morris -- James Morris