From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 6.1 0/5] Backport v6.2 SGID fixes to LTS 6.1
Date: Tue, 28 Feb 2023 19:44:21 +0100 [thread overview]
Message-ID: <Y/5LhTVMwLETrmlj@kroah.com> (raw)
In-Reply-To: <20230223152044.1064909-1-amir73il@gmail.com>
On Thu, Feb 23, 2023 at 05:20:39PM +0200, Amir Goldstein wrote:
> Greg,
>
> Following are backports of Christian's SGID fixes that were merged to
> v6.2-rc1.
>
> Note that Christain's PR [1] contains also two ovl patches (from me).
> Those two are independent fixes that have already been AUTOSELected
> to 6.1.y.
>
> Christain's fixes also contain a user observable change of behavior
> to fix inconsistencies of behavior between chmod/chown and write.
> This change is best described in Christain's commit to fix the expected
> behavior in xfstests [2].
>
> It is hoped that no applications rely on this minor behavioral
> difference, and if we are wrong, we may need to party revert the
> change, but in any case, we prefer the behavior of LTS kernels to be
> consitent with that of upstream.
>
> I ran the relevant fstests test groups on xfs and on overlayfs over xfs.
>
> I also have backports that I prepared for 5.15 and 5.10, but those
> backports include also xfs SGID fixes, so those need to go through the
> xfs stable review process.
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-02-28 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:20 [PATCH 6.1 0/5] Backport v6.2 SGID fixes to LTS 6.1 Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 1/5] attr: add in_group_or_capable() Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 2/5] fs: move should_remove_suid() Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 3/5] attr: add setattr_should_drop_sgid() Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 4/5] attr: use consistent sgid stripping checks Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 5/5] fs: use consistent setgid checks in is_sxid() Amir Goldstein
2023-02-28 18:44 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/5LhTVMwLETrmlj@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).