From: asmadeus@codewreck.org
To: Eric Van Hensbergen <ericvh@kernel.org>
Cc: v9fs-developer@lists.sourceforge.net, rminnich@gmail.com,
lucho@ionkov.net, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux_oss@crudebyte.com
Subject: Re: [PATCH v4 06/11] net/9p: fix bug in client create for .L
Date: Sat, 18 Feb 2023 17:01:47 +0900 [thread overview]
Message-ID: <Y/CF64nDuhoJtCmj@codewreck.org> (raw)
In-Reply-To: <20230218003323.2322580-7-ericvh@kernel.org>
Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 12:33:18AM +0000:
> We are supposed to set fid->mode to reflect the flags
> that were used to open the file. We were actually setting
> it to the creation mode which is the default perms of the
> file not the flags the file was opened with.
>
> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
I was about to say fcreate has the same problem, but TCREATE's mode
actually is the open mode (0 (called OREAD), 1 (OWRITE), 2 (ORDWR), and
3 (OEXEC)) and dotl's create is called perm :|
I guess that's where the mistake came from... Good catch!
(and there's also p9_wstat's mode which also is the perms to make things
more confusing...)
Anyway,
Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>
--
Dominique
next prev parent reply other threads:[~2023-02-18 8:02 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221217183142.1425132-1-evanhensbergen@icloud.com>
2022-12-18 23:22 ` [PATCH v2 00/10] Performance fixes for 9p filesystem Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 01/10] Adjust maximum MSIZE to account for p9 header Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 02/10] Expand setup of writeback cache to all levels Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 03/10] Consolidate file operations and add readahead and writeback Eric Van Hensbergen
2023-01-24 2:43 ` asmadeus
2023-01-24 3:03 ` Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 04/10] Remove unnecessary superblock flags Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 05/10] allow disable of xattr support on mount Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 06/10] fix bug in client create for .L Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 07/10] Add additional debug flags and open modes Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 08/10] Add new mount modes Eric Van Hensbergen
2023-01-24 3:35 ` Amir Goldstein
2022-12-18 23:22 ` [PATCH v2 09/10] fix error reporting in v9fs_dir_release Eric Van Hensbergen
2022-12-18 23:22 ` [PATCH v2 10/10] writeback mode fixes Eric Van Hensbergen
2023-01-23 16:31 ` [PATCH v2 00/10] Performance fixes for 9p filesystem Christian Schoenebeck
2023-01-24 2:33 ` evanhensbergen
2023-01-24 2:49 ` asmadeus
2023-01-24 2:38 ` [PATCH v3 00/11] " Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 01/11] Adjust maximum MSIZE to account for p9 header Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 02/11] Expand setup of writeback cache to all levels Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 03/11] Consolidate file operations and add readahead and writeback Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 04/11] Remove unnecessary superblock flags Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 05/11] allow disable of xattr support on mount Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 06/11] fix bug in client create for .L Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 07/11] Add additional debug flags and open modes Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 08/11] Add new mount modes Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 09/11] fix error reporting in v9fs_dir_release Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 10/11] writeback mode fixes Eric Van Hensbergen
2023-01-24 2:38 ` [PATCH v3 11/11] Fix revalidate Eric Van Hensbergen
2023-02-02 11:27 ` [PATCH v3 00/11] Performance fixes for 9p filesystem Christian Schoenebeck
2023-02-03 19:12 ` Eric Van Hensbergen
2023-02-04 13:40 ` Christian Schoenebeck
2023-02-04 21:38 ` Eric Van Hensbergen
2023-02-05 16:37 ` Eric Van Hensbergen
2023-02-06 13:20 ` Christian Schoenebeck
2023-02-06 13:37 ` Eric Van Hensbergen
2023-02-18 0:33 ` [PATCH v4 " Eric Van Hensbergen
2023-02-18 0:33 ` [PATCH v4 01/11] net/9p: Adjust maximum MSIZE to account for p9 header Eric Van Hensbergen
2023-02-18 7:50 ` asmadeus
2023-02-18 0:33 ` [PATCH v4 02/11] fs/9p: Expand setup of writeback cache to all levels Eric Van Hensbergen
2023-02-18 8:57 ` asmadeus
2023-02-18 0:33 ` [PATCH v4 03/11] fs/9p: Consolidate file operations and add readahead and writeback Eric Van Hensbergen
2023-02-18 9:24 ` asmadeus
2023-02-18 16:17 ` Eric Van Hensbergen
2023-02-18 16:19 ` Eric Van Hensbergen
2023-02-18 20:35 ` asmadeus
2023-02-27 2:50 ` [PATCH v5 3/11] " Eric Van Hensbergen
2023-02-18 0:33 ` [PATCH v4 04/11] fs/9p: Remove unnecessary superblock flags Eric Van Hensbergen
2023-02-18 9:33 ` asmadeus
2023-02-18 16:24 ` Eric Van Hensbergen
2023-02-18 20:30 ` asmadeus
2023-02-18 0:33 ` [PATCH v4 05/11] fs/9p: allow disable of xattr support on mount Eric Van Hensbergen
2023-02-18 7:52 ` asmadeus
2023-02-18 0:33 ` [PATCH v4 06/11] net/9p: fix bug in client create for .L Eric Van Hensbergen
2023-02-18 8:01 ` asmadeus [this message]
2023-02-18 0:33 ` [PATCH v4 07/11] 9p: Add additional debug flags and open modes Eric Van Hensbergen
2023-02-18 8:05 ` asmadeus
2023-02-27 2:53 ` [PATCH v5 7/11] " Eric Van Hensbergen
2023-02-18 0:33 ` [PATCH v4 08/11] fs/9p: Add new mount modes Eric Van Hensbergen
2023-02-18 8:46 ` asmadeus
2023-02-27 2:55 ` [PATCH v5 8/11] " Eric Van Hensbergen
2023-02-18 0:33 ` [PATCH v4 09/11] fs/9p: fix error reporting in v9fs_dir_release Eric Van Hensbergen
2023-02-18 8:49 ` asmadeus
2023-02-18 0:33 ` [PATCH v4 10/11] fs/9p: writeback mode fixes Eric Van Hensbergen
2023-02-18 8:38 ` asmadeus
2023-02-18 10:01 ` asmadeus
2023-02-18 12:15 ` asmadeus
2023-02-18 16:40 ` Eric Van Hensbergen
2023-02-18 20:29 ` asmadeus
2023-03-21 1:12 ` Eric Van Hensbergen
2023-02-18 19:58 ` Christian Schoenebeck
2023-02-18 22:24 ` Eric Van Hensbergen
2023-02-18 23:40 ` asmadeus
2023-02-18 23:52 ` Eric Van Hensbergen
2023-03-27 2:59 ` [PATCH v5] fs/9p: remove writeback fid and fix per-file modes Eric Van Hensbergen
2023-04-25 7:11 ` Christophe JAILLET
2023-04-25 11:13 ` asmadeus
2023-04-26 0:01 ` Eric Van Hensbergen
2023-02-18 0:33 ` [PATCH v4 11/11] fs/9p: Fix revalidate Eric Van Hensbergen
2023-02-18 8:55 ` asmadeus
2023-02-18 7:48 ` [PATCH v4 00/11] Performance fixes for 9p filesystem asmadeus
2023-02-19 21:36 ` Christian Schoenebeck
2023-02-20 1:13 ` Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/CF64nDuhoJtCmj@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=rminnich@gmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).