From: Matthew Wilcox <willy@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Aravinda Herle <araherle@in.ibm.com>
Subject: Re: [RFCv3 3/3] iomap: Support subpage size dirty tracking to improve write performance
Date: Sun, 26 Feb 2023 23:56:05 +0000 [thread overview]
Message-ID: <Y/vxlVUJ31PZYaRa@casper.infradead.org> (raw)
In-Reply-To: <20230226234814.GX360264@dread.disaster.area>
On Mon, Feb 27, 2023 at 10:48:14AM +1100, Dave Chinner wrote:
> > +static void iomap_iop_set_range_dirty(struct folio *folio,
> > + struct iomap_page *iop, size_t off, size_t len)
> > +{
> > + struct inode *inode = folio->mapping->host;
> > + unsigned int nr_blocks = i_blocks_per_folio(inode, folio);
> > + unsigned first = (off >> inode->i_blkbits);
> > + unsigned last = ((off + len - 1) >> inode->i_blkbits);
>
> first_bit, last_bit if we are leaving this code unchanged.
first_blk, last_blk, surely?
next prev parent reply other threads:[~2023-02-26 23:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 19:43 [RFCv3 0/3] iomap: Add support for subpage dirty state tracking to improve write performance Ritesh Harjani (IBM)
2023-02-26 19:43 ` [RFCv3 1/3] iomap: Allocate iop in ->write_begin() early Ritesh Harjani (IBM)
2023-02-26 22:41 ` Dave Chinner
2023-02-28 17:55 ` Ritesh Harjani
2023-02-26 23:12 ` Matthew Wilcox
2023-02-28 18:33 ` Ritesh Harjani
2023-02-28 18:36 ` Matthew Wilcox
2023-03-02 18:59 ` Ritesh Harjani
2023-02-26 19:43 ` [RFCv3 2/3] iomap: Change uptodate variable name to state Ritesh Harjani (IBM)
2023-02-26 23:12 ` Dave Chinner
2023-02-26 23:23 ` Matthew Wilcox
2023-02-28 18:38 ` Ritesh Harjani
2023-02-26 19:43 ` [RFCv3 3/3] iomap: Support subpage size dirty tracking to improve write performance Ritesh Harjani (IBM)
2023-02-26 23:48 ` Dave Chinner
2023-02-26 23:56 ` Matthew Wilcox [this message]
2023-02-27 0:10 ` Dave Chinner
2023-03-02 14:02 ` Brian Foster
2023-04-26 9:57 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/vxlVUJ31PZYaRa@casper.infradead.org \
--to=willy@infradead.org \
--cc=araherle@in.ibm.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).