From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Steve French <smfrench@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Shyam Prasad N <nspmangalore@gmail.com>,
Rohith Surabattula <rohiths.msft@gmail.com>,
Tom Talpey <tom@talpey.com>, Stefan Metzmacher <metze@samba.org>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
Jeff Layton <jlayton@kernel.org>,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Steve French <sfrench@samba.org>
Subject: Re: [PATCH 03/11] cifs: Implement splice_read to pass down ITER_BVEC not ITER_PIPE
Date: Mon, 6 Feb 2023 07:48:08 -0800 [thread overview]
Message-ID: <Y+EhOHVZWLjTq26h@infradead.org> (raw)
In-Reply-To: <20230203205929.2126634-4-dhowells@redhat.com>
On Fri, Feb 03, 2023 at 08:59:21PM +0000, David Howells wrote:
> Provide cifs_splice_read() to use a bvec rather than an pipe iterator as
> the latter cannot so easily be split and advanced, which is necessary to
> pass an iterator down to the bottom levels. Upstream cifs gets around this
> problem by using iov_iter_get_pages() to prefill the pipe and then passing
> the list of pages down.
Just as last time: if cifs has a problem with splitting these iters
so does everyone else. What about solving the root cause here?
If the splice isn't actually a splice you might as well not implement
it.
next prev parent reply other threads:[~2023-02-06 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:59 [PATCH 00/11] smb3: Use iov_iters down to the network transport and fix DIO page pinning David Howells
2023-02-03 20:59 ` [PATCH 01/11] netfs: Add a function to extract a UBUF or IOVEC into a BVEC iterator David Howells
2023-02-03 20:59 ` [PATCH 02/11] netfs: Add a function to extract an iterator into a scatterlist David Howells
2023-02-03 20:59 ` [PATCH 03/11] cifs: Implement splice_read to pass down ITER_BVEC not ITER_PIPE David Howells
2023-02-06 15:48 ` Christoph Hellwig [this message]
2023-02-03 20:59 ` [PATCH 04/11] cifs: Add a function to build an RDMA SGE list from an iterator David Howells
2023-02-03 20:59 ` [PATCH 05/11] cifs: Add a function to Hash the contents of " David Howells
2023-02-03 20:59 ` [PATCH 06/11] cifs: Add some helper functions David Howells
2023-02-03 20:59 ` [PATCH 07/11] cifs: Add a function to read into an iter from a socket David Howells
2023-02-03 20:59 ` [PATCH 08/11] cifs: Change the I/O paths to use an iterator rather than a page list David Howells
2023-02-03 20:59 ` [PATCH 09/11] cifs: Build the RDMA SGE list directly from an iterator David Howells
2023-02-03 20:59 ` [PATCH 10/11] cifs: Remove unused code David Howells
2023-02-03 20:59 ` [PATCH 11/11] cifs: DIO to/from KVEC-type iterators should now work David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+EhOHVZWLjTq26h@infradead.org \
--to=hch@infradead.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).