From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA57FA3744 for ; Mon, 31 Oct 2022 13:50:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbiJaNu2 (ORCPT ); Mon, 31 Oct 2022 09:50:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229849AbiJaNu1 (ORCPT ); Mon, 31 Oct 2022 09:50:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19F72101FA for ; Mon, 31 Oct 2022 06:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=iQrl5j+o4nSjJbyPNCGpMXm5FB yChHSnpCtAizwbsDoeW9pKo82bC5glMyHHQnquXDJ4OMdN72cwjlKzr6qfggnriV7Z5X8dJbbyy1C EwPoZYtZw0xammFqy8vhPmOWLViqasyeQQcpxAz4Gn2Lar3JOKSXDja3zZMHEE4isZxX1LbMjw+9u cZ+3aaqlXUvMEVZNFaFWjxxo0s2zOyeTmYU/V+4Qaq0Ya8Rmr71/xvrkhkgs3T/IryQJoBaZSL2DV kwp38NruB5MgMgBHFNsYryMvt03pTfJwXtJUhDsiOa9aUWzvghGr25gpw94oHfCcFYd0/BL6+mikv FOA6rtSA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1opVBD-00C8dz-9r; Mon, 31 Oct 2022 13:50:19 +0000 Date: Mon, 31 Oct 2022 06:50:19 -0700 From: Christoph Hellwig To: Gaosheng Cui Cc: hch@infradead.org, viro@zeniv.linux.org.uk, dhowells@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2] fs: fix undefined behavior in bit shift for SB_NOUSER Message-ID: References: <20221031134811.178127-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221031134811.178127-1-cuigaosheng1@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig