From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-mm@kvack.org, Uladzislau Rezki <urezki@gmail.com>,
Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ira Weiny <ira.weiny@intel.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH 1/1] mm: Add folio_map_local()
Date: Mon, 31 Oct 2022 15:14:31 +0000 [thread overview]
Message-ID: <Y1/mVxMhjLLFklxu@casper.infradead.org> (raw)
In-Reply-To: <2557442.1667229098@warthog.procyon.org.uk>
On Mon, Oct 31, 2022 at 03:11:38PM +0000, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
>
> > +static inline __must_check void *folio_map_local(struct folio *folio)
> > +{
> > + might_alloc(GFP_KERNEL);
> > +
> > + if (!IS_ENABLED(CONFIG_HIGHMEM))
> > + return folio_address(folio);
>
> Can you make the might_alloc() contingent on CONFIG_HIGHMEM=y?
... so that 64-bit builds can inadvertently introduce bugs? Either it's
safe to do GFP_KERNEL allocations from a given context, or it's not.
That's not going to depend on CONFIG_HIGHMEM.
prev parent reply other threads:[~2022-10-31 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 15:15 [PATCH 0/1] Mapping an entire folio Matthew Wilcox (Oracle)
2022-10-28 15:15 ` [PATCH 1/1] mm: Add folio_map_local() Matthew Wilcox (Oracle)
2022-11-01 10:12 ` Hyeonggon Yoo
2022-11-01 10:56 ` Uladzislau Rezki
2022-10-28 16:45 ` David Howells
2022-10-31 15:11 ` David Howells
2022-10-31 15:14 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1/mVxMhjLLFklxu@casper.infradead.org \
--to=willy@infradead.org \
--cc=david@fromorbit.com \
--cc=dhowells@redhat.com \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=tglx@linutronix.de \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).