From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
David Howells <dhowells@redhat.com>,
willy@infradead.org, dchinner@redhat.com,
Steve French <smfrench@gmail.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
Rohith Surabattula <rohiths.msft@gmail.com>,
Jeff Layton <jlayton@kernel.org>, Ira Weiny <ira.weiny@intel.com>,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 12/12] use less confusing names for iov_iter direction initializers
Date: Sun, 30 Oct 2022 05:01:39 +0000 [thread overview]
Message-ID: <Y14FM9svxLoaOOuS@ZenIV> (raw)
In-Reply-To: <CAHk-=wj4ndvhOFFsnNXRmwetwL9ZxE2QzcrLFTeJ7Yfh+pJ7Mw@mail.gmail.com>
On Fri, Oct 28, 2022 at 01:34:05PM -0700, Linus Torvalds wrote:
> On Fri, Oct 28, 2022 at 12:30 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Went through the callers, replaced each with the right ITER_... (there's
> > not that many of them and they are fairly easy to review), then went
> > through mismatches and split their fixups into the beginning of the
> > series (READ -> ITER_SOURCE becoming READ -> WRITE -> ITER_SOURCE, that
> > is).
>
> Oh, ok. So if you've actually reviewed each and every one of them,
> then I'm ok with the "abort".
>
> I still want it to be a WARN_ON_ONCE(), because of any future addition
> that gets things wrong.
Sure, np; branch updated and pushed out - the only difference is that
11/12 adds WARN_ON_ONCE instead of WARN_ON, so no point reposting, IMO...
next prev parent reply other threads:[~2022-10-30 5:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 15:26 How to convert I/O iterators to iterators, sglists and RDMA lists David Howells
2022-10-17 13:15 ` Christoph Hellwig
2022-10-20 14:03 ` David Howells
2022-10-21 3:30 ` Ira Weiny
2022-10-24 14:51 ` Christoph Hellwig
2022-10-24 14:57 ` Christoph Hellwig
2022-10-24 19:53 ` Al Viro
2022-10-28 2:33 ` [PATCH v2 01/12] get rid of unlikely() on page_copy_sane() calls Al Viro
2022-10-28 2:33 ` [PATCH v2 02/12] csum_and_copy_to_iter(): handle ITER_DISCARD Al Viro
2022-10-28 2:33 ` [PATCH v2 03/12] [s390] copy_oldmem_kernel() - WRITE is "data source", not destination Al Viro
2022-10-28 2:33 ` [PATCH v2 04/12] [fsi] " Al Viro
2022-10-28 2:33 ` [PATCH v2 05/12] [infiniband] READ is "data destination", not source Al Viro
2022-10-28 2:33 ` [PATCH v2 06/12] [s390] zcore: WRITE is "data source", not destination Al Viro
2022-10-28 2:33 ` [PATCH v2 07/12] [s390] memcpy_real(): " Al Viro
2022-10-28 2:33 ` [PATCH v2 08/12] [target] fix iov_iter_bvec() "direction" argument Al Viro
2022-10-28 2:33 ` [PATCH v2 09/12] [vhost] fix 'direction' argument of iov_iter_{init,bvec}() Al Viro
2022-10-28 2:33 ` [PATCH v2 10/12] [xen] fix "direction" argument of iov_iter_kvec() Al Viro
2022-10-28 12:48 ` John Stoffel
2022-10-28 12:49 ` John Stoffel
2022-10-28 2:33 ` [PATCH v2 11/12] iov_iter: saner checks for attempt to copy to/from iterator Al Viro
2022-10-28 2:33 ` [PATCH v2 12/12] use less confusing names for iov_iter direction initializers Al Viro
2022-10-28 16:41 ` Linus Torvalds
2022-10-28 17:15 ` Al Viro
2022-10-28 18:35 ` Linus Torvalds
2022-10-28 19:30 ` Al Viro
2022-10-28 20:34 ` Linus Torvalds
2022-10-30 5:01 ` Al Viro [this message]
2022-10-28 17:02 ` David Howells
2022-10-28 17:09 ` Linus Torvalds
2022-10-30 8:12 ` [PATCH v2 01/12] get rid of unlikely() on page_copy_sane() calls Christoph Hellwig
2022-11-01 13:51 ` How to convert I/O iterators to iterators, sglists and RDMA lists Christoph Hellwig
2022-10-28 17:31 ` David Howells
2022-11-04 18:47 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y14FM9svxLoaOOuS@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=smfrench@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).