From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Brian Foster <bfoster@redhat.com>, Linux-MM <linux-mm@kvack.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
jesus.a.arechiga.lopez@intel.com, tim.c.chen@linux.intel.com
Subject: Re: writeback completion soft lockup BUG in folio_wake_bit()
Date: Tue, 25 Oct 2022 20:19:44 +0100 [thread overview]
Message-ID: <Y1g20GUTu6mOq+CJ@casper.infradead.org> (raw)
In-Reply-To: <CAHk-=wj7mRYuictrQjT+sacgj9_GrmRetE1KLTiz-nOk-H4DPQ@mail.gmail.com>
On Mon, Oct 24, 2022 at 01:28:31PM -0700, Linus Torvalds wrote:
> It does sound like we now very much have hard data for "the page
> waitlist complexity is now a bigger problem than the historical
> problem it tried to solve".
>
> So I'll happily apply it. The only question is whether it's a "let's
> do this for 6.2", or if it's something that we'd want to back-port
> anyway, and might as well apply sooner rather than later as a fix.
>
> I think that in turn then depends on just how artificial the test case
> was. If the test case was triggered by somebody seeing problems in
> real life loads, that would make the urgency a lot higher. But if it
> was purely a synthetic test case with no accompanying "this is what
> made us look at this" problem, it might be a 6.2 thing.
>
> Arechiga?
>
> Also, considering that Willy authored the patch (even if it's really
> just a "remove this whole code logic"), maybe he has opinions? Willy?
I've been carrying a pair of patches in my tree to rip out the wait
bookmarks since March, waiting for me to write a userspace testcase to
reproduce the problem against v4.13 and then check it no longer does so
against v5.0. Unfortunately, that hasn't happened. I'm happy to add
Arechiga's Tested-by, and submit them to Andrew and have him bring them
into v6.2, since this doesn't seem urgent?
next prev parent reply other threads:[~2022-10-25 19:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 19:07 writeback completion soft lockup BUG in folio_wake_bit() Brian Foster
2022-03-16 20:59 ` Matthew Wilcox
2022-03-16 23:35 ` Linus Torvalds
2022-03-17 15:04 ` Matthew Wilcox
2022-03-17 19:26 ` Linus Torvalds
2022-03-17 21:16 ` Matthew Wilcox
2022-03-17 22:52 ` Dave Chinner
2022-03-18 13:16 ` Jan Kara
2022-03-18 18:56 ` Linus Torvalds
2022-03-19 16:23 ` Theodore Ts'o
2022-03-30 15:55 ` Christoph Hellwig
2022-03-17 15:31 ` Brian Foster
2022-03-17 13:51 ` Brian Foster
2022-03-18 14:14 ` Brian Foster
2022-03-18 14:45 ` Matthew Wilcox
2022-03-18 18:58 ` Linus Torvalds
2022-10-20 1:35 ` Dan Williams
2022-10-23 22:38 ` Linus Torvalds
2022-10-24 19:39 ` Tim Chen
2022-10-24 19:43 ` Linus Torvalds
2022-10-24 20:14 ` Dan Williams
2022-10-24 20:13 ` Dan Williams
2022-10-24 20:28 ` Linus Torvalds
2022-10-24 20:35 ` Dan Williams
2022-10-25 15:58 ` Arechiga Lopez, Jesus A
2022-10-25 19:19 ` Matthew Wilcox [this message]
2022-10-25 19:20 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1g20GUTu6mOq+CJ@casper.infradead.org \
--to=willy@infradead.org \
--cc=bfoster@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hughd@google.com \
--cc=jesus.a.arechiga.lopez@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).