From: Matthew Wilcox <willy@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCHv2] iomap: directly use logical block size
Date: Thu, 3 Nov 2022 16:30:40 +0000 [thread overview]
Message-ID: <Y2PssKdUUtmWNvTW@casper.infradead.org> (raw)
In-Reply-To: <20221103154339.2150274-1-kbusch@meta.com>
On Thu, Nov 03, 2022 at 08:43:39AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2022-11-03 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 15:43 [PATCHv2] iomap: directly use logical block size Keith Busch
2022-11-03 16:30 ` Matthew Wilcox [this message]
2022-11-04 5:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2PssKdUUtmWNvTW@casper.infradead.org \
--to=willy@infradead.org \
--cc=bvanassche@acm.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=kch@nvidia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).