* [PATCHv2] iomap: directly use logical block size
@ 2022-11-03 15:43 Keith Busch
2022-11-03 16:30 ` Matthew Wilcox
2022-11-04 5:13 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2022-11-03 15:43 UTC (permalink / raw)
To: linux-fsdevel
Cc: linux-kernel, Keith Busch, Christoph Hellwig, Chaitanya Kulkarni,
Darrick J . Wong, Bart Van Assche
From: Keith Busch <kbusch@kernel.org>
Don't transform the logical block size to a bit shift only to shift it
back to the original block size. Just use the size.
Cc: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
v1->v2:
Get rid of the temporary variable since it's only used once (hch)
fs/iomap/direct-io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index 4eb559a16c9e..9804714b1751 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -240,7 +240,6 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
{
const struct iomap *iomap = &iter->iomap;
struct inode *inode = iter->inode;
- unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev));
unsigned int fs_block_size = i_blocksize(inode), pad;
loff_t length = iomap_length(iter);
loff_t pos = iter->pos;
@@ -252,7 +251,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
size_t copied = 0;
size_t orig_count;
- if ((pos | length) & ((1 << blkbits) - 1) ||
+ if ((pos | length) & (bdev_logical_block_size(iomap->bdev) - 1) ||
!bdev_iter_is_aligned(iomap->bdev, dio->submit.iter))
return -EINVAL;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCHv2] iomap: directly use logical block size
2022-11-03 15:43 [PATCHv2] iomap: directly use logical block size Keith Busch
@ 2022-11-03 16:30 ` Matthew Wilcox
2022-11-04 5:13 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2022-11-03 16:30 UTC (permalink / raw)
To: Keith Busch
Cc: linux-fsdevel, linux-kernel, Keith Busch, Christoph Hellwig,
Chaitanya Kulkarni, Darrick J . Wong, Bart Van Assche
On Thu, Nov 03, 2022 at 08:43:39AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] iomap: directly use logical block size
2022-11-03 15:43 [PATCHv2] iomap: directly use logical block size Keith Busch
2022-11-03 16:30 ` Matthew Wilcox
@ 2022-11-04 5:13 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-11-04 5:13 UTC (permalink / raw)
To: Keith Busch
Cc: linux-fsdevel, linux-kernel, Keith Busch, Christoph Hellwig,
Chaitanya Kulkarni, Darrick J . Wong, Bart Van Assche
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-04 5:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03 15:43 [PATCHv2] iomap: directly use logical block size Keith Busch
2022-11-03 16:30 ` Matthew Wilcox
2022-11-04 5:13 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).