From: Eric Biggers <ebiggers@kernel.org>
To: Alexander Potapenko <glider@google.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
chao@kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org,
syzbot+9767be679ef5016b6082@syzkaller.appspotmail.com
Subject: Re: [PATCH] fs: ext4: initialize fsdata in pagecache_write()
Date: Mon, 14 Nov 2022 18:20:37 +0000 [thread overview]
Message-ID: <Y3KG9bAo11t84SIg@gmail.com> (raw)
In-Reply-To: <20221114082935.3007497-1-glider@google.com>
On Mon, Nov 14, 2022 at 09:29:35AM +0100, Alexander Potapenko wrote:
> [PATCH] fs: ext4: initialize fsdata in pagecache_write()
>
> When aops->write_begin() does not initialize fsdata, KMSAN reports
> an error passing the latter to aops->write_end().
>
> Fix this by unconditionally initializing fsdata.
>
> Also speculatively fix similar issues in affs, f2fs, hfs, hfsplus,
> as suggested by Eric Biggers.
You might have better luck with separate patches for each filesystem, as it
might be hard to get someone to apply this patch otherwise.
If you do go with a single patch, then the subject prefix should be "fs:", not
"fs: ext4:".
- Eric
next prev parent reply other threads:[~2022-11-14 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 8:29 [PATCH] fs: ext4: initialize fsdata in pagecache_write() Alexander Potapenko
2022-11-14 18:20 ` Eric Biggers [this message]
2022-11-21 11:23 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3KG9bAo11t84SIg@gmail.com \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=chao@kernel.org \
--cc=glider@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+9767be679ef5016b6082@syzkaller.appspotmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).