From: Matthew Wilcox <willy@infradead.org>
To: Denis Arefev <arefev@swemel.ru>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
trufanov@swemel.ru, vfh@swemel.ru
Subject: Re: [PATCH] namespace: Added pointer check in copy_mnt_ns()
Date: Wed, 16 Nov 2022 18:16:43 +0000 [thread overview]
Message-ID: <Y3UpC8AT8gTeupib@casper.infradead.org> (raw)
In-Reply-To: <20221116091255.84576-1-arefev@swemel.ru>
On Wed, Nov 16, 2022 at 12:12:55PM +0300, Denis Arefev wrote:
> Return value of a function 'next_mnt' is dereferenced at
> namespace.c:3377 without checking for null,
> but it is usually checked for this function
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
You need to do human analysis, not just send the results from a bot.
What conditions can lead to this function returning NULL? Do we
already know those conditions can or cannot hold?
next prev parent reply other threads:[~2022-11-16 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 9:12 [PATCH] namespace: Added pointer check in copy_mnt_ns() Denis Arefev
2022-11-16 18:16 ` Matthew Wilcox [this message]
2022-11-17 13:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3UpC8AT8gTeupib@casper.infradead.org \
--to=willy@infradead.org \
--cc=arefev@swemel.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trufanov@swemel.ru \
--cc=vfh@swemel.ru \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox