From: Eric Biggers <ebiggers@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] btrfs: replace INT_LIMIT(loff_t) with OFFSET_MAX
Date: Mon, 21 Nov 2022 19:57:03 +0000 [thread overview]
Message-ID: <Y3vYDyjqf68jDdo/@gmail.com> (raw)
In-Reply-To: <20221121024418.1800-2-thunder.leizhen@huawei.com>
On Mon, Nov 21, 2022 at 10:44:17AM +0800, Zhen Lei wrote:
> OFFSET_MAX is self-annotated and more readable.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> fs/btrfs/ordered-data.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
> index e54f8280031fa14..100d9f4836b177d 100644
> --- a/fs/btrfs/ordered-data.c
> +++ b/fs/btrfs/ordered-data.c
> @@ -761,11 +761,11 @@ int btrfs_wait_ordered_range(struct inode *inode, u64 start, u64 len)
> struct btrfs_ordered_extent *ordered;
>
> if (start + len < start) {
> - orig_end = INT_LIMIT(loff_t);
> + orig_end = OFFSET_MAX;
> } else {
> orig_end = start + len - 1;
> - if (orig_end > INT_LIMIT(loff_t))
> - orig_end = INT_LIMIT(loff_t);
> + if (orig_end > OFFSET_MAX)
> + orig_end = OFFSET_MAX;
> }
>
> /* start IO across the range first to instantiate any delalloc
> --
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2022-11-21 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 2:44 [PATCH v2 0/2] fs: clear a UBSAN shift-out-of-bounds warning Zhen Lei
2022-11-21 2:44 ` [PATCH v2 1/2] btrfs: replace INT_LIMIT(loff_t) with OFFSET_MAX Zhen Lei
2022-11-21 17:30 ` David Sterba
2022-11-21 19:57 ` Eric Biggers [this message]
2022-11-21 2:44 ` [PATCH v2 2/2] fs: clear a UBSAN shift-out-of-bounds warning Zhen Lei
2022-11-21 19:57 ` Eric Biggers
2022-11-25 6:43 ` [PATCH v2 0/2] " Al Viro
2022-11-25 8:33 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3vYDyjqf68jDdo/@gmail.com \
--to=ebiggers@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).