From: Al Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: simplify vfs_get_super
Date: Fri, 25 Nov 2022 04:32:36 +0000 [thread overview]
Message-ID: <Y4BFZEBT6eDZfYPu@ZenIV> (raw)
In-Reply-To: <20221121075032.GA24804@lst.de>
On Mon, Nov 21, 2022 at 08:50:32AM +0100, Christoph Hellwig wrote:
> On Mon, Oct 31, 2022 at 01:46:26PM +0100, Christoph Hellwig wrote:
> > Remove the pointless keying argument and associated enum and pass the
> > fill_super callback and a "bool reconf" instead. Also mark the function
> > static given that there are no users outside of super.c.
>
> Al, can you pick this one up?
Applied, even though I want to see if we can lift sget_fc() out of that
thing and turn it into something that would just handle the "here's
a superblock, here's fc, here's fill_super callback, do the right
thing" part and hopefully might be reused in bdev part...
next prev parent reply other threads:[~2022-11-25 4:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 12:46 [PATCH] fs: simplify vfs_get_super Christoph Hellwig
2022-11-21 7:50 ` Christoph Hellwig
2022-11-25 4:32 ` Al Viro [this message]
2022-11-28 12:01 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4BFZEBT6eDZfYPu@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).