From: Gao Xiang <xiang@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: Jingbo Xu <jefflexu@linux.alibaba.com>,
jlayton@kernel.org, xiang@kernel.org, chao@kernel.org,
linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] fscache,cachefiles: add prepare_ondemand_read() callback
Date: Fri, 25 Nov 2022 21:01:21 +0800 [thread overview]
Message-ID: <Y4C8ocemviAGpxRC@debian> (raw)
In-Reply-To: <2386961.1669377478@warthog.procyon.org.uk>
Hi David,
On Fri, Nov 25, 2022 at 11:57:58AM +0000, David Howells wrote:
> Jingbo Xu <jefflexu@linux.alibaba.com> wrote:
>
> > Add prepare_ondemand_read() callback dedicated for the on-demand read
> > scenario, so that callers from this scenario can be decoupled from
> > netfs_io_subrequest.
> >
> > The original cachefiles_prepare_read() is now refactored to a generic
> > routine accepting a parameter list instead of netfs_io_subrequest.
> > There's no logic change, except that the debug id of subrequest and
> > request is removed from trace_cachefiles_prep_read().
> >
> > Reviewed-by: Jeff Layton <jlayton@kernel.org>
> > Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
>
> Acked-by: David Howells <dhowells@redhat.com>
Thanks! I will apply them for -next, and soon Jingbo will
submit large folios support for erofs iomap/fscache modes.
Thank all again,
Gao Xiang
prev parent reply other threads:[~2022-11-25 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 3:42 [PATCH v5 0/2] fscache,cachefiles: add prepare_ondemand_read() interface Jingbo Xu
2022-11-24 3:42 ` [PATCH v5 1/2] fscache,cachefiles: add prepare_ondemand_read() callback Jingbo Xu
2022-11-24 3:42 ` [PATCH v5 2/2] erofs: switch to prepare_ondemand_read() in fscache mode Jingbo Xu
2022-11-24 8:07 ` [Linux-cachefs] " Jia Zhu
2022-11-25 11:57 ` [PATCH v5 1/2] fscache,cachefiles: add prepare_ondemand_read() callback David Howells
2022-11-25 13:01 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4C8ocemviAGpxRC@debian \
--to=xiang@kernel.org \
--cc=chao@kernel.org \
--cc=dhowells@redhat.com \
--cc=jefflexu@linux.alibaba.com \
--cc=jlayton@kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).