From: Matthew Wilcox <willy@infradead.org>
To: yang.yang29@zte.com.cn
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, iamjoonsoo.kim@lge.com
Subject: Re: [PATCH linux-next] swap_state: update shadow_nodes for anonymous page
Date: Thu, 29 Dec 2022 17:03:21 +0000 [thread overview]
Message-ID: <Y63IWTOE4sNKuseL@casper.infradead.org> (raw)
In-Reply-To: <202212292130035747813@zte.com.cn>
On Thu, Dec 29, 2022 at 09:30:03PM +0800, yang.yang29@zte.com.cn wrote:
> From: Yang Yang <yang.yang29@zte.com.cn>
>
> Shadow_nodes is for shadow nodes reclaiming of workingset handling,
> it is updated when page cache add or delete since long time ago
> workingset only supported page cache. But when workingset supports
> anonymous page detection[1], we missied updating shadow nodes for
> it.
Please include a description of the user-visible effect of this (I
think I can guess, but I'd like it spelled out)
> [1] commit aae466b0052e ("mm/swap: implement workingset detection for anonymous LRU")
>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
No Fixes: line? It doesn't need to be backported?
> ---
> include/linux/xarray.h | 3 ++-
> mm/swap_state.c | 4 ++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/xarray.h b/include/linux/xarray.h
> index 44dd6d6e01bc..cd2ccb09c596 100644
> --- a/include/linux/xarray.h
> +++ b/include/linux/xarray.h
> @@ -1643,7 +1643,8 @@ static inline void xas_set_order(struct xa_state *xas, unsigned long index,
> * @update: Function to call when updating a node.
> *
> * The XArray can notify a caller after it has updated an xa_node.
> - * This is advanced functionality and is only needed by the page cache.
> + * This is advanced functionality and is only needed by the page cache
> + * and anonymous page.
... "and swap cache.", not anonymous page.
next prev parent reply other threads:[~2022-12-29 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 13:30 [PATCH linux-next] swap_state: update shadow_nodes for anonymous page yang.yang29
2022-12-29 17:03 ` Matthew Wilcox [this message]
2022-12-30 1:36 ` yang.yang29
2023-01-03 1:44 ` yang.yang29
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y63IWTOE4sNKuseL@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).