linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Yun Levi <ppbuk5246@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [Question] Unlinking original file of bind mounted file.
Date: Fri, 30 Dec 2022 10:58:04 +0000	[thread overview]
Message-ID: <Y67EPM+fIu41hlCO@casper.infradead.org> (raw)
In-Reply-To: <CAM7-yPQOZx85f3KxKO1feSPcwYTZGRNNVEgqn4D_+nhhXvqQzQ@mail.gmail.com>

On Fri, Dec 30, 2022 at 05:08:31PM +0900, Yun Levi wrote:
> Hello fs-devel folks,
> 
> I have a few questions about below situation's handling.
> 
> ======================================================
> 1. mount --bind {somefile} {target}
> 2. rm -f {somefile}
> =======================================================
> 
> when it happens, the step (2)'s operation is working -- it removes.
> But, the inode of {somefile} is live with i_nlink = 0 with an orphan
> state of ext4_inode_info in ext4-fs.
> 
> IIUC, because ext4-inode-entry is removed in the disk via ext4_unlink,
> and it seems possible
> the inode_entry which is freed by unlink in step(2) will be used again
> when a new file is created.

No, that's not correct.  Here's how to think about Unix files (not just
ext4, going all the way back to the 1970s).  Each inode has a reference
count.  All kinds of things hold a reference count to an inode; some of
the more common ones are a name in a directory, an open file, a mmap of
that open file, passing a file descriptor through a unix socket, etc, etc.

Unlink removes a name from a directory.  That causes the reference count
to be decreased, but the inode will only be released if that causes the
reference count to drop to 0.  If the file is open, or it has multiple
names, it won't be removed.

mount --bind obviously isn't traditional Unix, but it fits in the same
paradigm.  It causes a new reference count to be taken on the inode.
So you can remove the original name that was used to create the link,
and that causes i_nlink to drop to 0, but the in-memory refcount is
still positive, so the inode will not be reused.


  reply	other threads:[~2022-12-30 10:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30  8:08 [Question] Unlinking original file of bind mounted file Yun Levi
2022-12-30 10:58 ` Matthew Wilcox [this message]
     [not found]   ` <CAM7-yPROANYjeGn3ECfqmn0sLzEQPUpzCyU5zSN3-mJv3UA4CA@mail.gmail.com>
2022-12-30 11:16     ` Fwd: " Yun Levi
2022-12-30 21:51       ` Eric Biggers
2022-12-30 22:58         ` Yun Levi
2022-12-30 23:05           ` Eric Biggers
2022-12-31  4:35             ` Yun Levi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y67EPM+fIu41hlCO@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ppbuk5246@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).