From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B97BC54EBC for ; Thu, 12 Jan 2023 07:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236797AbjALHc3 (ORCPT ); Thu, 12 Jan 2023 02:32:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbjALHc2 (ORCPT ); Thu, 12 Jan 2023 02:32:28 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62E03391; Wed, 11 Jan 2023 23:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fzTsI/XfuD28OOI8CbmCAj26l5GkvrEUKgk/R0u9xL8=; b=A1J+hoTRw2rXyWH5xGcBAeQNVb OXD9g0nslx5lo5eU18QDAeabzNXWrVDJu4TFYlo96H7jBuxN6wHoU96rkBh1CLAKbMJPNHTKfOCVE XnAm1mBGbfrRDblNlCPKM6YXicYQZ5rjYf7M9Elvjp/0oHQc+77R6K5Lp+aF0oY2iigIVQG5Euptp zZkrKaqaTG6cdCBSrBNsZeIpiDAiMkkCBWtv03OEtIvfo+wTWm2ITL+khinKNMYnpmghGGdljTMlW ql3zWAY+v43fbf70Mfe+S83shPTcc04PXb3qcFEoxfp/YwFKyNchiIxbF+sceaPUANzsYrOLOj3kX Vdv1IcrQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFs4M-00E12U-3x; Thu, 12 Jan 2023 07:32:14 +0000 Date: Wed, 11 Jan 2023 23:32:14 -0800 From: Christoph Hellwig To: David Howells Cc: Al Viro , Jens Axboe , Jan Kara , Matthew Wilcox , Logan Gunthorpe , linux-block@vger.kernel.org, Christoph Hellwig , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 7/9] bio: Rename BIO_NO_PAGE_REF to BIO_PAGE_REFFED and invert the meaning Message-ID: References: <167344725490.2425628.13771289553670112965.stgit@warthog.procyon.org.uk> <167344730802.2425628.14034153595667416149.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167344730802.2425628.14034153595667416149.stgit@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org I'd rename the flag to BIO_PAGES_REFFED as it can effect multiple pages, but otherwise this looks good: Reviewed-by: Christoph Hellwig